Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(Checkbox): remove incorrect event combinations #3691

Merged
merged 1 commit into from
Jul 7, 2019

Conversation

layershifter
Copy link
Member

In #3435 we introduced changes to Checkbox tests, but these was a mistake in cycles.

We should pass event names instead of array to simulant.fire().

@codecov-io
Copy link

Codecov Report

Merging #3691 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3691   +/-   ##
=======================================
  Coverage   99.83%   99.83%           
=======================================
  Files         175      175           
  Lines        3116     3116           
=======================================
  Hits         3111     3111           
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c884fa9...28de573. Read the comment docs.

@layershifter layershifter merged commit 8f83dad into master Jul 7, 2019
@delete-merged-branch delete-merged-branch bot deleted the test/checkbox branch July 7, 2019 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants