Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Label): add prompt prop #3680

Merged
merged 1 commit into from
Jun 23, 2019
Merged

feat(Label): add prompt prop #3680

merged 1 commit into from
Jun 23, 2019

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Jun 23, 2019

This PR adds prompt prop to Label component. It used only inside Forms that can indicate errors:

Validation messages can also appear inline. UI Forms automatically format labels with the class name prompt. These validation prompts are also set to appear on input change instead of form submission.

https://semantic-ui.com/behaviors/form.html#validating-on-blur-and-other-events


Styles applied to <Label prompt /> are different that usual:

image

@codecov-io
Copy link

Codecov Report

Merging #3680 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3680   +/-   ##
=======================================
  Coverage   99.83%   99.83%           
=======================================
  Files         174      174           
  Lines        3100     3100           
=======================================
  Hits         3095     3095           
  Misses          5        5
Impacted Files Coverage Δ
src/elements/Label/Label.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7774e6...fbfeb55. Read the comment docs.

@layershifter layershifter merged commit a25809e into master Jun 23, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat/label-prompt branch June 23, 2019 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants