fix(Modal): do not close when mouse click was occurred inside

[joergbaier]

The default modal closes when:

1. When a click starts in the modal but ends in the dimmer
2. When a click starts in the dimmer but ends in the modal

This can be reproduced in the first example
https://react.semantic-ui.com/modules/modal/

This change will only close the Modal if the click starts and ends in the dimmer.

[welcome]

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

• Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
• Run yarn test locally to catch errors. This ensures all components still behave as they should.
• Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
• Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

[codecov-io]

Codecov Report

Merging #3582 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3582      +/-   ##
==========================================
+ Coverage   99.81%   99.81%   +<.01%     
==========================================
  Files         174      174              
  Lines        2737     2743       +6     
==========================================
+ Hits         2732     2738       +6     
  Misses          5        5

Impacted Files	Coverage Δ
src/modules/Modal/Modal.js	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6751d0...e2c7b50. Read the comment docs.

[joergbaier]

It looks like #3575 could use the same change as well.

[mihai-dinculescu]

I'm not sure if changing the tests from domEvent.click to domEvent.mouseDown and domEvent.mouseUp is the right aproach. This will not hit the onClick handlers and will act differently from reality. I believe that my aproach from #3575 to update domEvent.click to also fire mousedown and mouseup is more resilient.

[joergbaier]

@mihai-dinculescu I will update this PR to match yours tomorrow.

[welcome]

Congrats on merging your first pull request! 🎉🎉🎉

[fraynn]

Thanks for fixing this issue. Do you have any idea on when we can expect this fix to be pushed to npm ?

[layershifter]

I think that we will finally make a release on this week 🎉