Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Input): update supported values for the size prop #3444

Merged
merged 1 commit into from
Feb 17, 2019

Conversation

layershifter
Copy link
Member

Fixes #3439.

This PR updates supported values for the size prop, see input.css.

@codecov-io
Copy link

Codecov Report

Merging #3444 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3444   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         172      172           
  Lines        2838     2838           
=======================================
  Hits         2836     2836           
  Misses          2        2
Impacted Files Coverage Δ
src/elements/Input/Input.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8365c90...489cc45. Read the comment docs.

@layershifter layershifter merged commit d1eb9c2 into master Feb 17, 2019
@layershifter layershifter deleted the fix/input-remove-tiny branch February 17, 2019 11:45
@levithomason
Copy link
Member

Released in semantic-ui-react@0.86.0.

@woozyking
Copy link

Would this be a breaking change, since previously there was medium size supported?

This came up only when we ran some snapshot testing on our data table component, as seen https://travis-ci.com/EQWorks/extended-semantic-components/builds/105847120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants