fix(Rating): conditionally set tabIndex when element is disabled #3308
+25
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set tabIndex to -1 (no focus) if Rating element is disabled.
Codecov Report
@@ Coverage Diff @@
## master #3308 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 170 170
Lines 2803 2803
=======================================
Hits 2801 2801
Misses 2 2
Continue to review full report at Codecov.
|
|
Fantastic, thanks for the work, write up, and tests ❤️ |
levithomason
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As raised in #3252, RatingIcons can be individually focused when navigating with Tab, which doesn't make sense as users cannot select disabled elements anyway.
However, thinking a bit further, still makes sense to be able to focus the whole element so it can still be accessible (i.e.: users with vision impairment can still be aware of its existence).
So the solution was to set
RatingIcontabIndex = -1(reference) and at the same time keepingtabIndex = 0in theRatingcomponent, when the whole element is indisabledstate.The demo:
Also added test cases.
PS.: I just noticed that some lines in the test file where unintentionally reformatted, I guess we have new lint/prettier rules?
(closes #3252)