chore(build): update babel deps, fix production build of docs and build on Windows #3214
+2,157
−243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
commented
Oct 12, 2018
| }) | ||
|
|
||
| const { task, series, parallel } = require('gulp') | ||
| const path = require('path') |
There was a problem hiding this comment.
Fix for react-static/react-static#776
layershifter
commented
Oct 12, 2018
| } | ||
|
|
||
| cb(new Error(`child process exited with code ${code}`)) | ||
| }) | ||
| } |
There was a problem hiding this comment.
Codecov Report
@@ Coverage Diff @@
## master #3214 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 169 169
Lines 2790 2790
=======================================
Hits 2788 2788
Misses 2 2Continue to review full report at Codecov.
|
|
A manually tested staging build, works fine 👍 |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: