Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(package): restore babel option modules: false for ESM builds #2663

Merged
merged 2 commits into from
Mar 19, 2018
Merged

chore(package): restore babel option modules: false for ESM builds #2663

merged 2 commits into from
Mar 19, 2018

Conversation

thetric
Copy link
Contributor

@thetric thetric commented Mar 19, 2018 •
edited by layershifter
Loading

Fixes #2661.

@codecov-io
Copy link

codecov-io commented Mar 19, 2018 •
edited
Loading

Codecov Report

Merging #2663 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2663   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files         160      160           
  Lines        2751     2751           
=======================================
  Hits         2744     2744           
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3af0503...3e6f450. Read the comment docs.

@layershifter layershifter changed the title build: restore babel option modules: false for webpack's tree shaking chore(package): restore babel option modules: false for ESM builds Mar 19, 2018
@layershifter layershifter merged commit 564bf8a into Semantic-Org:master Mar 19, 2018
@layershifter
Copy link
Member

Thanks 👍

@levithomason
Copy link
Member

Released in semantic-ui-react@0.79.0.

@thetric thetric deleted the iss-2661 branch March 19, 2018 21:42
@dependabot-preview dependabot-preview bot mentioned this pull request Mar 20, 2018
Merged
layershifter pushed a commit that referenced this pull request Mar 20, 2018
@thetric @layershifter
chore(package): restore babel option modules: false for ESM builds (#…
aa0f7a6 
…2663)

* build: restore babel option `modules: false` for webpack's tree shaking

this closes #2661

* Update preset-env.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thetric @codecov-io @layershifter @levithomason