-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(layouts): make HomepageLayout responsive #2396
Conversation
@brianespinosa Your feedback is much needed there |
Codecov Report
@@ Coverage Diff @@
## master #2396 +/- ##
=======================================
Coverage 99.73% 99.73%
=======================================
Files 152 152
Lines 2664 2664
=======================================
Hits 2657 2657
Misses 7 7 Continue to review full report at Codecov.
|
@layershifter just getting back from the holidays. I just assigned this to myself and will take a deeper look later this afternoon. 👍 |
@layershifter & @brianespinosa I think this solution breaks the Server Side Rendering. I actually tried to do the similar thing at: /~https://github.com/dongcai/react-redux-semantic-ui/blob/master/src/components/Navigation/Navigation.js |
@dongcai please make a minimal repro repo and open new issue. |
@layershifter Sorry... my workload exploded this month. I haven't even been on github in two weeks. I will try to get some eyes on this by Monday. Apologies for the delay. |
Merged as is, we can always to fix it in future 👍 |
Thanks @layershifter Additionally... I meant to bring this up here and with @levithomason , it might be good to update the layout of the docs in general to make the side menu available to toggle on/off. Maybe just update the style of the docs in general in preparation for 1.0. But I think this looks good for now. 👍 |
Definitely agree. We should use the actual Sidebar component. I think it needs #1408 before that can be done properly. |
Released in |
Fixes: #2386