docs(webpack): add webpack3 boilerplate with theming #2371
Conversation
| ### [webpack2][29] | ||
| Our example project right [here][29] in this repo. | ||
| ### [webpack][28] | ||
| Our example project right [here][28] in this repo. Includes theming examples. |
There was a problem hiding this comment.
Webpack 1&2 is outdated, we need only one boilerplate for latest version.
| @@ -199,12 +196,11 @@ Big thanks to our [contributors][20], especially: | |||
| [21]: /~https://github.com/Semantic-Org/Semantic-UI-React/labels/good%20first%20issue | |||
| [22]: /~https://github.com/Semantic-Org/Semantic-UI-React/edit/master/README.md | |||
| [23]: https://react.semantic-ui.com/usage#css | |||
| [24]: https://github.com/Semantic-Org/Semantic-UI-React/issues/802#issuecomment-258990274 | |||
| [24]: https://medium.com/webmonkeys/webpack-2-semantic-ui-theming-a216ddf60daf | |||
There was a problem hiding this comment.
I've updated link as information there has more value for our users.
|
@brianespinosa @levithomason It will be awesome to get feedback from you there. Grammar fixes is much appreciated 😸 |
Codecov Report
@@ Coverage Diff @@
## master #2371 +/- ##
=======================================
Coverage 99.73% 99.73%
=======================================
Files 152 152
Lines 2661 2661
=======================================
Hits 2654 2654
Misses 7 7Continue to review full report at Codecov.
|
|
Very cool, thanks for this! I'm just wrapping my session for today. I want to give this PR the attention it deserves, so that may come at a later date. ❤️ |
There was a problem hiding this comment.
Everything else looks good. Just a few grammar and copy changes I am suggesting.
I saw that we are also using the beta version of babel-loader and @babel. Is this for JSX fragments? I try to stay away from beta releases on packages if I can avoid it.
docs/app/Views/Theming.js
Outdated
| <Header as='h2' content='Preface' dividing /> | ||
| <p> | ||
| Semantic UI React does not have own styling system and fully relies on the theming of Semantic UI. It's really | ||
| powerfull, you don't need to know LESS or CSS you can simply update values of variables or use styles from |
docs/app/Views/Theming.js
Outdated
|
|
||
| <Header as='h2' content='Quick start' dividing /> | ||
| <p> | ||
| Semantic UI offers own build system that uses Gulp and produces prepared CSS files. It makes sence to use it |
There was a problem hiding this comment.
"Semantic UI offers its own build system..."
sence > sense
docs/app/Views/Theming.js
Outdated
|
|
||
| <Header as='h2' content='Boilerplate' dividing /> | ||
| <p> | ||
| If you are looking a boilerplate, we prepared it. It powered by latest Webpack and includes the all required |
There was a problem hiding this comment.
"The boilerplate we prepared is powered by the latest Webpack and includes the all required things for quick start like preconfigured theming and hot module reload."
Babel 7 is much faster and enough stable now. I'm use it in my project last few weeks and I really like it. I almost sure that it will be released soon as stable and it makes no sence to make bet on Babel 6 now to me. |
|
Looks like we have approvals here. In the future @layershifter, if you get multiple approvals and are confident, please feel free to merge without me. I don't want to hinder progress and I have trust for everyone we're adding to the team. Note, @layershifter has been here a long time and has master merge rights. I control releases, but anything that makes it to master will make the next release cycle. |
|
Looks a bad merge on this guy. Build is failing. Might need to roll it back, or make a fix PR. See master on CircleCI. |
|
It's a long term problem with tests:
I can't to find out the reason locally, very strange issue. Last build was successed. |
|
Random intermittent failure I suppose. Thanks. |
|
Released in |
* docs(webpack): add webpack3 boilerplate with theming * docs(webpack): fix grammar
|
@levithomason is there much to change in order to responsibly load SUIR in Webpack v4, seeing how tree shaking/code splitting actually works in this version? |
Rel #1636.
This PR adds the missed information about theming and adds the real boilerplate 😺
Boilerplate features