fix(eventStack): correct handling of removed targets #2117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
commented
Sep 25, 2017
| @@ -49,10 +46,12 @@ class EventStack { | |||
| if (!isBrowser) return | |||
|
|
|||
| const { target = document, pool = 'default' } = options | |||
| const eventTarget = this._find(target) | |||
| const eventTarget = this._find(target, false) | |||
There was a problem hiding this comment.
Before this change, _find created always new instance of EventTarget when it was removed
Codecov Report
@@ Coverage Diff @@
## master #2117 +/- ##
=======================================
Coverage 99.76% 99.76%
=======================================
Files 150 150
Lines 2596 2596
=======================================
Hits 2590 2590
Misses 6 6Continue to review full report at Codecov.
|
|
@levithomason This problem looks quite critical to me. Can you review this and release |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rel #2075#comment.
Changes:
eventStacknow usesMapunsub