fix(TextArea): use onInput for updating height for IE compatibility #1982
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1982 +/- ##
=========================================
+ Coverage 99.8% 99.8% +<.01%
=========================================
Files 148 148
Lines 2561 2563 +2
=========================================
+ Hits 2556 2558 +2
Misses 5 5
Continue to review full report at Codecov.
|
|
One minor conflict here, could you take a look? |
nickpedersen
force-pushed
the
fix/ie-auto-height
branch
from
ee01292 to
459a3db
Compare
levithomason
force-pushed
the
fix/ie-auto-height
branch
from
94a01c4 to
459a3db
Compare
levithomason
force-pushed
the
fix/ie-auto-height
branch
from
459a3db to
1a94e6c
Compare
|
@nickpedersen / @layershifter I've rebased, fixed conflicts, and cleaned up typings. I think this is good to go. Can you take a look and confirm? |
|
I've removed useless export, now tests are passing. I don't have IE at now, so I can't test. @nickpedersen can you take a look? |
|
Just tested, can confirm it's working in IE11. Appreciate the help on this PR @layershifter and @levithomason |
|
Thanks guys! |
|
Released in |
…1982) * fix(TextArea): use onInput for updating height for IE compatibility * fix(TextArea): cleanup onChange and onInput typings * fix(typings): remove useless export
Fixes #1925
This is my first PR, apologies if there are any mistakes.
Added an onInput method to the TextArea component, copying the onChange pattern. Added a test for the onInput method.
Tested in IE11 and the requested behaviour (cutting and pasting) correctly resizes the TextArea.