fix signature begin determination

[ktomk]

previously the begin of the signature was determined based on the stub-
length.

NOTE: determining the signature begin based on manifest parser end position
can lead to overwriting the last byte of the last file in the phar
with the first byte of the hash.

this ignored the size of the manifest.

fix is to take the end of the manifest which is known due to it's size
and add the compressed file sizes to it instead of adding this to the
internal position of the parser that runs only to detect the compressed
file sizes. authoritative is the manifest size.

[Seldaek]

Just gonna assume you did your research here, because I frankly don't feel like digging into this again right now :)

[ktomk]

Let's say I did my research.

And just in case for some future reference, I've tagged the commits locally where the problems arose so the revisions don't go away. It was always reproducible (when the files put into the phar are the same).

[ktomk]

For future reference, I've pushed the three tags just to have this transparent:

• fix-phar-utils-OK - known development revision that was OK
• fix-phar-utils-FIRST-FAIL - the next known development revision that triggered a PHP error
• fix-phar-utils-FIRST-FATAL - the then next known revision that did even trigger a fatal error

These tags keep the revisions in the distributed Github repository of ktomk/pipelines.