-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New SciML/Optimization for fitting parameters of ODEs tutorial tutorial #740
New SciML/Optimization for fitting parameters of ODEs tutorial tutorial #740
Conversation
b35dbbc
to
60372f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about fitting multiple data sets that should have the same parameters simultaneously? (i.e. if the experiment has been run multiple times) Do we show this anywhere?
using OptimizationOptimisers # Required for the ADAM optimizer. | ||
using SciMLSensitivity # Required for `Optimization.AutoZygote()` automatic differentiation option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using OptimizationOptimisers # Required for the ADAM optimizer. | |
using SciMLSensitivity # Required for `Optimization.AutoZygote()` automatic differentiation option. | |
using OptimizationOptimisers # for the ADAM optimizer | |
using SciMLSensitivity # for Optimization.AutoZygote() AD backend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer the old version. Especially spelling out the AD part (As I imagine most people are unfamiliar with this, and especially just "AD backend" doesn't say much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I generally try to make my comments full sentences, not sure if there is some standard regarding this though.
I think I looked at demonstrating this as well, but it was just really messy so I decided not to do it (was a while ago, so don't really remember). There is a section mentioning that this is possible, and linking to where DiffEqParamEstim describes it though:
We also show how to do this for PEtab. |
Co-authored-by: Sam Isaacson <isaacsas@users.noreply.github.com>
Co-authored-by: Sam Isaacson <isaacsas@users.noreply.github.com>
Co-authored-by: Sam Isaacson <isaacsas@users.noreply.github.com>
Co-authored-by: Sam Isaacson <isaacsas@users.noreply.github.com>
Co-authored-by: Sam Isaacson <isaacsas@users.noreply.github.com>
Co-authored-by: Sam Isaacson <isaacsas@users.noreply.github.com>
Co-authored-by: Sam Isaacson <isaacsas@users.noreply.github.com>
Co-authored-by: Sam Isaacson <isaacsas@users.noreply.github.com>
Co-authored-by: Sam Isaacson <isaacsas@users.noreply.github.com>
Co-authored-by: Sam Isaacson <isaacsas@users.noreply.github.com>
Co-authored-by: Sam Isaacson <isaacsas@users.noreply.github.com>
Co-authored-by: Sam Isaacson <isaacsas@users.noreply.github.com>
Co-authored-by: Sam Isaacson <isaacsas@users.noreply.github.com>
Co-authored-by: Sam Isaacson <isaacsas@users.noreply.github.com>
Co-authored-by: Sam Isaacson <isaacsas@users.noreply.github.com>
Co-authored-by: Sam Isaacson <isaacsas@users.noreply.github.com>
Co-authored-by: Sam Isaacson <isaacsas@users.noreply.github.com>
Co-authored-by: Sam Isaacson <isaacsas@users.noreply.github.com>
Co-authored-by: Sam Isaacson <isaacsas@users.noreply.github.com>
5f6ad74
to
0251301
Compare
Things updated and rebased on the latest v14 branch, thanks for the input! |
Feel free to merge when you feel this is done and sufficiently revised. |
Thanks for the input :) I will have a second read-through tonight just to be sure, and will merge afterwards. |
A new version of this one: #708
Adds a tutorial of how to use DiffEqParamEstim and Optimization for parameter fitting. Those packages are still not properly adapted to symbolic indexing, so normal vectors have to be used. However, I still think we go with that (I can add an additional note box at the beginning if we want to highlight this).
I still think this is better than self-coding this stuff (easy-to-miss stuff like what happens if a solver fails) so think this is useful (PEtab is still probably the best alternative). Also, hopefully, we can use this as a template workflow that we think should work without indexing, and something DiffEqParamEstim + Optimization should work towards fixing.