test: added an edge case in ReactionSystem

[sivasathyaseeelan]

I have added an edge cases to test ReactionSystem which were not tested before.

Checklist

• Appropriate tests were added
• Any code changes were done in a way that does not break public API
• All documentation related to code changes were updated
• The new code follows the
  contributor guidelines, in particular the SciML Style Guide and
  COLPRAC.
• Any new documentation only uses public API

Additional context

Add any other context about the problem here.

[TorkelE]

The test is well written, but I don't see how this tests something relevant to the package? I.e. if I understand it correct, what we want to test is that if the user updates the Catalyst.forbidden_symbols_error list with a new forbidden variable, then these cannot be used?

I am mostly surprised that the user can update Catalyst.forbidden_symbols_error, which really isn;t something anyone should do.

Is this looking at a specific line in the code which we do not have coverage on? In that case we could have al ook at it to see if there is a better way to cover it.

Even if we do not end up using this, still thanks for your effort with the PR!

[TorkelE]

Should be S(t), species should always depend on an independent variable.

[sivasathyaseeelan]

The test is well written, but I don't see how this tests something relevant to the package? I.e. if I understand it correct, what we want to test is that if the user updates the Catalyst.forbidden_symbols_error list with a new forbidden variable, then these cannot be used?

I am mostly surprised that the user can update Catalyst.forbidden_symbols_error, which really isn;t something anyone should do.

Is this looking at a specific line in the code which we do not have coverage on? In that case we could have al ook at it to see if there is a better way to cover it.

Even if we do not end up using this, still thanks for your effort with the PR!

I thought of creating some random forbidden symbols. I will remove it and replace it with any exiting forbidden symbol

Also this covers the below condition

[TorkelE]

sounds good

[TorkelE]

Also, you might want to use test_throws to check whether a line of code generates an error.

[TorkelE]

https://docs.julialang.org/en/v1/stdlib/Test/#Test.@test_throws

[TorkelE]

Looking closer, this seems like a repeat of

    # System using a forbidden symbol.
    @test_throws Exception rs = ReactionSystem([Reaction(Γ, [X1], [])], t; named = :rs)

from the test block just above yours.

However, there is an error in that test that means that that specific error is not hit (named should be name). if you want you can fix that bug error though :)

[sivasathyaseeelan]

Looking closer, this seems like a repeat of

    # System using a forbidden symbol.
    @test_throws Exception rs = ReactionSystem([Reaction(Γ, [X1], [])], t; named = :rs)

from the test block just above yours.

However, there is an error in that test that means that that specific error is not hit (named should be name). if you want you can fix that bug error though :)

I will fix the bug in previous test and remove the new test set!

[TorkelE]

Thanks, will merge once everything passes.