Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[errors] Package should leverage standard library errors.Is and errors.As methods since the ecosystem is going toward this direction #582

Closed
Soulou opened this issue Apr 5, 2023 · 0 comments · Fixed by #583
Assignees

Comments

@Soulou
Copy link
Member

Soulou commented Apr 5, 2023

As a follow up of some discussions of our workshop

@Soulou Soulou self-assigned this Apr 5, 2023
Soulou pushed a commit that referenced this issue Apr 5, 2023
…for error value of type

I'm proposing to deprecate IsRootCause and if(errors.RootCause(err) == something to use errors.As(err, errWithExpectedType) errors.Is(err, something)

Fixes #582
Soulou pushed a commit that referenced this issue Apr 5, 2023
…for error value of type

I'm proposing to deprecate IsRootCause and if(errors.RootCause(err) == something to use errors.As(err, errWithExpectedType) errors.Is(err, something)

Fixes #582
Soulou pushed a commit that referenced this issue Apr 6, 2023
Soulou pushed a commit that referenced this issue Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant