Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(middleware): add a middleware to set the content-type to application/json #97

Merged
merged 4 commits into from
Jul 18, 2024
Merged

feat(middleware): add a middleware to set the content-type to application/json #97

merged 4 commits into from
Jul 18, 2024

Conversation

SCedricThomas
Copy link
Contributor

  • Add a changelog entry in the CHANGELOG.md file, in the "To be Released" section.
  • As much as possible, do not deprecate parameters. Only add new parameters.

@SCedricThomas SCedricThomas self-assigned this Jul 18, 2024
@SCedricThomas SCedricThomas requested review from EtienneM and removed request for EtienneM July 18, 2024 14:59
EtienneM
EtienneM approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@EtienneM EtienneM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of suggestions, feel free to take them into account or not. Already approving the PR.

Can you also update the cron service?

CHANGELOG.md Outdated Show resolved Hide resolved
content_type_middleware.go Outdated Show resolved Hide resolved
SCedricThomas and others added 3 commits July 18, 2024 17:04
@SCedricThomas
fix(middleware): call the handler in the return
d9de8ea
@SCedricThomas @EtienneM
Update CHANGELOG.md
9d63950 
Co-authored-by: Étienne M. <EtienneM@users.noreply.github.com>
@SCedricThomas @EtienneM
Update content_type_middleware.go
68a5d4a 
Co-authored-by: Étienne M. <EtienneM@users.noreply.github.com>
@SCedricThomas SCedricThomas enabled auto-merge July 18, 2024 15:06
@SCedricThomas SCedricThomas merged commit b383aaf into master Jul 18, 2024
2 checks passed
@SCedricThomas SCedricThomas deleted the feat/json-content-type-middleware branch July 18, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EtienneM EtienneM EtienneM approved these changes

Assignees

@SCedricThomas SCedricThomas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SCedricThomas @EtienneM