Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run.py: Prioritize sibling modules over installed modules #2772

Merged
merged 4 commits into from
Feb 10, 2024

Conversation

krzywon
Copy link
Contributor

@krzywon krzywon commented Jan 21, 2024

Description

This PR prioritizes sibling packages over installed packages when launching run.py. This should better enable developers to modify sibling packages without the need for pip installation. This fix only applies to sasmodels, sasdata, bumps, and periodictable, but could be generalized to any package held in requirements.txt.

Review Checklist (please remove items if they don't apply):

  • Code has been reviewed
  • Functionality has been tested
  • Windows installer (GH artifact) has been tested (installed and worked)
  • MacOSX installer (GH artifact) has been tested (installed and worked)
  • Developers documentation is available and complete (if required)

…sily enable modifications to parallel sibling packages
Copy link
Member

@rozyczko rozyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected.

@wpotrzebowski wpotrzebowski merged commit e7eea71 into release_6.0.0 Feb 10, 2024
36 checks passed
@wpotrzebowski wpotrzebowski deleted the sibling_module_priority branch February 10, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants