Release 6.0.0 notarization fix #2709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rozyczko
approved these changes
Jan 17, 2024
| "SasView*.app/Contents/Resources/PySide6/Qt/lib/Qt*.framework/Versions/A/Qt*", recursive=True | ||
| ) | ||
|
|
||
| #pyside_libs = pyside_QtWebEngineCore + pyside_QtWebEngineProcess |
There was a problem hiding this comment.
Why do we need to notarize Qt libraries? They are already signed by the Qt Company, after all?
Unless this is something very macos specific? But then, we don't notarize other libraries we depend on...
There was a problem hiding this comment.
@rozyczko: Yeah, good question. Once they are touched e.g. packaged with pyinstaller they need to be signed again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR should fix notarization for release_6.0.0, so that Mac builds should pass now
Fixes # (issue/issues)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Review Checklist (please remove items if they don't apply):