Improved/fixed category manager

[rozyczko]

Description

The Category Manager has been pretty neglected over the years, so it is time to fix it properly.

Fixes #2584

How Has This Been Tested?

Locally on Win10

Review Checklist (please remove items if they don't apply):

• Code has been reviewed
• Functionality has been tested
• Windows installer (GH artifact) has been tested (installed and worked)
• MacOSX installer (GH artifact) has been tested (installed and worked)

[wpotrzebowski]

If I am testing it correctly it works fine. The issue raised by @krzywon needs to be addressed but may be a subject of separate issue/pr?

[wpotrzebowski]

@rozyczko will take a look at it

[krzywon]

The issue I noted is now fixed, but main was merged into this branch instead of release_6.0.0. There are (only) 4 commits in main not in the release branch, but we should discuss whether these should be removed from here or not.

[rozyczko]

Modified the target to main, since this branch was based off of it.
Merging it with main will make it possible to cherry-pick the changes to release_6.0.0

[butlerpd]

Doing functionality testing the installer on windows 10, I found several small issues:

• The help button doesn't work though there is a small section in the documentation about it. Other help buttons do work. However that button does not work in 5.0.6 so this could be turned into another issue and separated from this pull request
• The documentation needs to be updated as well. However most of the changes relate to things prior to this fix so this could also be moved to another issue and separated from this pull request
• The category changes, including any new categories created do not persist after exiting the program.
• Most importantly, if a built in model has a second category added to it, while it shows up in both categories till exiting the program, when you restart SasView, the model is read in as disabled and does not show up in any category. This definitely needs to be fixed.

[wpotrzebowski]

@rozyczko do you think we should address requested changes in this PR or separate? Also do we want to rebase to 6.0.0 or is it a "nice to have" feature that having it in 6.0.0 is not a priority?

[rozyczko]

@rozyczko do you think we should address requested changes in this PR or separate? Also do we want to rebase to 6.0.0 or is it a "nice to have" feature that having it in 6.0.0 is not a priority?

I think this needs a bit more work, given persistence issues noted by @butlerpd . Let's prioritize it out of 6.0, if possible.

[rozyczko]

Issues reported by @butlerpd have been fixed (except of the documentation update)

Please retest

[butlerpd]

WOW .. very nice!! Sorry @rozyczko I failed to see this in the bustle of the final day of camp.

I have fairly thoroughly tested now I think using the installer for windows and it is a finally a pleasure to work with modulo a couple of minor glitches which I would not allow to prevent this from being included in 6.0.0! I list them below nonetheless:

• the Kill button is greyed out and does not work (and there are no minimize/maximize buttons). Hitting the OK button closes the window but that does break the general expectations of how windows behave? But there may be some complications there?
• Any new categories created do not appear in the list of available categories in the Category Manager dropdown when modifying a model. This even after exiting and restarting SasView. As long as one makes no spelling mistakes it works fine .. otherwise you can easily create another category by accident. Moreover it seems a bit odd to have to click "create new" category then type exactly the same as the one previously created. This would be presumably the biggest use case: adding a bunch of models to "my most used models" category. Still not a show stopper at all.
• Adding a category to a plugin model does not automatically "enable" it. This means the model still shows up in plugins (no way to disable plugins other than by deleting them but that makes sense to me), but it will not appear in the category just assigned unless one ALSO checks the enable box. Not sure that is the best/desired behavior? If so then at least it should be documented in the updated documentation (a separate PR) as it is not the most intuitive.
• The help button does not go to the desired section but that is due to a long standing problem with calling sections out in help. That should be fixed with the new "documentation editor" PR.

[butlerpd]

NOTE: I just realized that the problem with the kill button was probably fixed by PR #2690 which was against 6.0. Once 6.0 is merged into main (see PR #2808) this should be fixed automatically.

[butlerpd]

@wpotrzebowski to give a final check but otherwise read to merge