Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2350: Close the BUMPS/DREAM results panel when data is deleted #2365

Merged
merged 3 commits into from
Nov 8, 2022

Conversation

krzywon
Copy link
Contributor

@krzywon krzywon commented Nov 1, 2022

Description

The Bumps convergence window now closes when the data it shows is deleted. This also updates the results panel title to show the same name as the data explorer and fit panel.

Fixes #2350

How Has This Been Tested?

Steps I followed:

  • Loaded a data set
  • Sent to fit and ran fit using LM
  • Verified convergence window is displayed
  • Deleted data set and verified convergence window no longer shown
  • Loaded three data sets (data1, data2, and data3)
  • Sent data1 and data2 to fitting
  • Fit data1 using LM and verified convergence window is displayed for data1
  • Fit data2 using LM and verified convergence window is displayed for data2
  • Delete data1 and verified the convergence window still displays data2
  • Delete data3 and verified the convergence window still displays data2
  • Delete data2 and verified convergence window no longer shown

Review Checklist (please remove items if they don't apply):

  • Code has been reviewed
  • Functionality has been tested
  • Windows installer (GH artifact) has been tested (installed and worked)
  • MacOSX installer (GH artifact) has been tested (installed and worked)
  • Developers documentation is available and complete (if required)
  • The introduced changes comply with SasView license (BSD 3-Clause)

@krzywon krzywon requested review from rozyczko and smk78 November 1, 2022 16:19
@rozyczko
Copy link
Member

rozyczko commented Nov 1, 2022

The results panel for the deleted job can still be shown when choosing Fitting/Fit Results.
I understand this is as designed?

Copy link
Member

@rozyczko rozyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, minor naming style issue raised.

@krzywon
Copy link
Contributor Author

krzywon commented Nov 2, 2022

Not as designed. All data is now removed from the panel when data is deleted.

@rozyczko
Copy link
Member

rozyczko commented Nov 2, 2022

Not as designed. All data is now removed from the panel when data is deleted.

Looks fixed now. All good.

Oh well, did Edit comment rather than quote reply. Sorry for modifying your comment.
Looks fixed now.

@butlerpd butlerpd added the Discuss At The Call Issues to be discussed at the fortnightly call label Nov 7, 2022
@butlerpd butlerpd merged commit fa56cb1 into main Nov 8, 2022
@butlerpd butlerpd deleted the 2350-delete-closes-dream-panel branch November 8, 2022 14:29
@butlerpd butlerpd removed the Discuss At The Call Issues to be discussed at the fortnightly call label Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting data does not remove the DREAM results panel
3 participants