Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple slicers of the same slicer type #2604

Closed
astellhorn opened this issue Sep 11, 2023 · 0 comments · Fixed by #2610
Closed

Allow multiple slicers of the same slicer type #2604

astellhorn opened this issue Sep 11, 2023 · 0 comments · Fixed by #2610
Labels
Enhancement Feature requests and/or general improvements

Comments

@astellhorn
Copy link
Contributor

This issue is related to issue "Allow multiple slicers on a data set #2503"

Request in the old issue:
(i) Allowing a wedge slicer - that has been implemented already by Ellis
(ii) Allowing multiple slicers (independent/dependent, overlapping/not overlapping, same/different type)

Request in this issue (subfeature of issue "2503"):
Would like to allow the multiplication of one slicer type to start with. This function can then be adopted later, when multiple different slicers are made possible at the same time

Is your feature request related to a problem? Please describe.
In magnetic SANS, several different slicers have to be implemented in one view/data set, independent of the type of slicer

Describe the solution you'd like

  • Any type of slicer should have following options: (i) saving this slicer (ii) editing its (saved) parameters (iii) being multiplied in Q and /or phi (iv) slicer can be cleared
  • My proposition is the structure in the following image
  • that has several advantages: (i) for the analysis of e.g. multiple bragg peaks multiple (same-kind) slicers can be opened in the same 2Dview/dataset, (ii) slicers can be saved and reopened even if another type of slicer has been tested in between

Mulitplication single slicer

Describe alternatives you've considered

  • It is questionnable if the multiplication option should be handled first for a single slicer type, or directly of a combination of different slicers - to avoid double-work and a complicated code structure
  • The option for different slicers would have following further requirements: (i) an overlap needs to be possible, (ii) different slicers need to be able to be plotted in the 1D/2D views
  • My proposition: After having inserted the single-slicer-multiplication, this can be transferred to the functions of multiple (different) slicers as follows:

Several slicers simultaneously

Questions / to discuss for the single-kind multiplied slicers

  • How to plot the 1D plot of the multiplied slicer?
  • E.g. for a slicer multiplied at several Q: in the same plot-window with continuous Q-range on the x-axis, and plotted as "sum" of all defined Q-sections?

Questions / to discuss for the Multiple different-kind slicers

  • For multiple (different type) slicers each single created one should/must be saved first to display all created types in the 2D view?
  • How to handle the 1D plotting of different types of slicers? The best probably independent in different views, not as sum?
@astellhorn astellhorn added the Enhancement Feature requests and/or general improvements label Sep 11, 2023
@astellhorn astellhorn linked a pull request Sep 17, 2023 that will close this issue
7 tasks
krzywon added a commit that referenced this issue Sep 18, 2023
…the-same-slicer-type

created submenu for slicers being part of #2604
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Feature requests and/or general improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant