Accept error (missing textEdit.range)

[3rd]

Hi, I've been hitting this weird issue where textEdit.range is nil when selecting a completion.
I never manager to hit it when working with Lua, but when working with TypeScript it's frequent.
Thank you for all the work!

ts_get_from_item.mp4

[Saghen]

This might be the same as #21. There's a solution in that thread

[3rd]

Ah I tried, I just checked textDocument.completion.completionItem for all the LSPs.

"cssmodules_ls"
{
  commitCharactersSupport = false,
  deprecatedSupport = false,
  documentationFormat = { "markdown", "plaintext" },
  insertReplaceSupport = false,
  preselectSupport = false,
  snippetSupport = false
}
"eslint"
{
  commitCharactersSupport = false,
  deprecatedSupport = false,
  documentationFormat = { "markdown", "plaintext" },
  insertReplaceSupport = false,
  preselectSupport = false,
  snippetSupport = false
}
"tailwindcss"
{
  commitCharactersSupport = false,
  deprecatedSupport = false,
  documentationFormat = { "markdown", "plaintext" },
  insertReplaceSupport = false,
  preselectSupport = false,
  snippetSupport = false
}
"typescript-tools"
{
  commitCharactersSupport = false,
  deprecatedSupport = false,
  documentationFormat = { "markdown", "plaintext" },
  preselectSupport = false,
  snippetSupport = false
}
"ast_grep"
{
  commitCharactersSupport = false,
  deprecatedSupport = false,
  documentationFormat = { "markdown", "plaintext" },
  insertReplaceSupport = false,
  preselectSupport = false,
  snippetSupport = false
}
"lua_ls"
{
  commitCharactersSupport = false,
  deprecatedSupport = false,
  documentationFormat = { "markdown", "plaintext" },
  insertReplaceSupport = false,
  preselectSupport = false,
  snippetSupport = false
}

[Saghen]

My best guess is the LSP is returning a itemDefaults.editRange which I have yet to add support for. Do me a favor and send the output of this snippet at the position where the error occurs:

vim.lsp.buf_request_all(
  0,
  'textDocument/completion',
  vim.lsp.util.make_position_params(),
  function(result) vim.print(result) end
)

The LSP shouldn't be sending this since we don't advertise support but some LSPs seem to ignore that bit of the spec

[3rd]

Logged it here: https://gist.ro/blink.txt

The weird part is that it only happens when the completion menu shows up after ., but if I type any prefix like .f| everything works fine 👀

I added a check to prevent throwing the error, but it introduced a side-effect of duplicating dots when navigating the menu (so . -> -> ..member) and introducing a third dot on accept (-> ...member)

[Saghen]

Reproduced it with typescript-tools and this looks to be the same as #21. You might want to use ts_ls or vtsls temporarily as I can't see a way to disable this behavior with typescript-tools

[Saghen]

Scratch that, it was surprisingly trivial to workaround this temporarily

[3rd]

Works great, thank you!