Remove most deprecated APIs and enumerators #1881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vittorioromeo
changed the title
vittorioromeo
changed the title
eXpl0it3r
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes almost every deprecated API and entity in SFML, with the notable exception of
sf::PrimitiveType::Quadswhich will be handled in a separate PR.The removed APIs have been marked as deprecated for literally years, and it is about time we do some clean-up :)
Users have had plenty of time and warnings to stop using deprecated APIs, and SFML 3.x offers us the possibility to perform a clean break and completely remove them from the codebase. Migration from a deprecated API to a modern one is quite simple in all the cases covered by this PR, except for
sf::PrimitiveType::Quadswhich might require a bit more discussion.Tasks
How to test this PR?
CI.