Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenAI test payload #70

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Update OpenAI test payload #70

merged 1 commit into from
Oct 2, 2024

Conversation

CharlesDuboisSAP
Copy link
Contributor

@CharlesDuboisSAP CharlesDuboisSAP commented Sep 27, 2024

Context

AI/ai-sdk-java-backlog#66.

Updated the outdated unit test payload for OpenAI.

Feature scope:

  • Fetched a new payload
  • Updated the test assertions (Model classes were already up to date)

Definition of Done

  • Functionality scope stated & covered
  • Tests cover the scope above
  • Error handling created / updated & covered by the tests above
  • Aligned changes with the JavaScript SDK
  • Documentation updated
  • Release notes updated

"created": 1719300073,
"id": "chatcmpl-9dumHtDEyysGFnknk17n4Lt37tg7T",
"model": "gpt-4-32k",
"content": "I'm an AI and cannot answer that question as beauty is subjective and varies from person to person.",
Copy link
Contributor Author

@CharlesDuboisSAP CharlesDuboisSAP Sep 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a new field content which is not in the Azure spec, neither in the OpenAI documentation

Also, I found no place that documents the change from selfHarm to self_harm.

Copy link
Contributor

@newtork newtork Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect this content to be a serialization mistake somewhere.
Currently, we're not parsing this new field, and we're not planning to do so.

@CharlesDuboisSAP CharlesDuboisSAP enabled auto-merge (squash) September 30, 2024 11:47
@@ -24,13 +25,13 @@
"filtered": false,
"severity": "safe"
},
"selfHarm": null,
"self_harm": {
Copy link
Contributor

@newtork newtork Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Comment)
looks like spec was corrected to proper snake_case

@CharlesDuboisSAP CharlesDuboisSAP merged commit b2330c4 into main Oct 2, 2024
5 checks passed
@CharlesDuboisSAP CharlesDuboisSAP deleted the test-payload branch October 2, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants