Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed e2e-test-app to sample-code/spring-app #61

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Conversation

CharlesDuboisSAP
Copy link
Contributor

@CharlesDuboisSAP CharlesDuboisSAP commented Sep 18, 2024

Context

AI/ai-sdk-java-backlog#52.

As a user, I want to have some sample code so that I can get a better idea how to use the AI SDK in a typical BTP application.

Feature scope:

  • Renamed e2e-test-app to sample-code/spring-app
  • Added README in spring-app
  • Fix links in main README

Definition of Done

  • Functionality scope stated & covered
  • Tests cover the scope above
  • Error handling created / updated & covered by the tests above
  • Aligned changes with the JavaScript SDK
  • Documentation updated
  • Release notes updated

Reviewer notes

A follow-up PR will be created in which the code samples will be permalinks instead of code blocks

@CharlesDuboisSAP CharlesDuboisSAP self-assigned this Sep 18, 2024
Copy link
Member

@MatKuhr MatKuhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

as discussed, improving the main readme can/should be done with a separate PR

@CharlesDuboisSAP CharlesDuboisSAP merged commit cf2b8f3 into main Sep 18, 2024
5 checks passed
@CharlesDuboisSAP CharlesDuboisSAP deleted the sample-code branch September 18, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants