Added Orchestration Data Masking tests #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry e2e tests and maskingAnonymization unit test
CharlesDuboisSAP
changed the title
CharlesDuboisSAP
changed the title
newtork
reviewed
Oct 2, 2024
| @@ -66,6 +75,33 @@ public class OrchestrationUnitTest { | |||
| .templatingModuleConfig(templatingModuleConfig))) | |||
| .inputParams(Map.of()); | |||
|
|
|||
| private static final Function<MaskingProviderConfig.MethodEnum, CompletionPostRequest> | |||
| MASKING_CONFIG = | |||
| (MaskingProviderConfig.MethodEnum maskingType) -> { | |||
There was a problem hiding this comment.
(Comment)
I didn't know you can add type def signature in lambda syntax ^^
newtork
reviewed
Oct 2, 2024
orchestration/src/test/java/com/sap/ai/sdk/orchestration/client/OrchestrationUnitTest.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Oct 2, 2024
| .getResourceAsStream("templatingRequest.json") | ||
| .readAllBytes()); | ||
| verify(postRequestedFor(urlPathEqualTo("/completion")).withRequestBody(equalToJson(request))); | ||
| void templating() throws IOException { |
There was a problem hiding this comment.
(Comment)
(Still) not a fan of dropping the test method name prefix.
newtork
reviewed
Oct 2, 2024
orchestration/src/test/java/com/sap/ai/sdk/orchestration/client/OrchestrationUnitTest.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Oct 2, 2024
...le-code/spring-app/src/main/java/com/sap/ai/sdk/app/controllers/OrchestrationController.java
Show resolved
Hide resolved
newtork
reviewed
Oct 2, 2024
| * | ||
| * @return the assistant message response | ||
| */ | ||
| @GetMapping("/maskingPseudonymization") |
There was a problem hiding this comment.
- @GetMapping("/maskingPseudonymization")
+ @GetMapping("/maskingPseudoAnonymization")
There was a problem hiding this comment.
Why? Orchestration calls it pseudonymization.
… into feat/orchestration-data-masking
MatKuhr
commented
Oct 2, 2024
MatKuhr
commented
Oct 2, 2024
orchestration/src/test/java/com/sap/ai/sdk/orchestration/client/OrchestrationUnitTest.java
Outdated
Show resolved
Hide resolved
MatKuhr
commented
Oct 2, 2024
orchestration/src/test/java/com/sap/ai/sdk/orchestration/client/OrchestrationUnitTest.java
Outdated
Show resolved
Hide resolved
CharlesDuboisSAP
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
AI/ai-sdk-java-backlog#70.
As an orchestration user I want to anonymize and pseudonymize my input prompts using the data masking capabilites of orchestration.
Feature scope:
Definition of Done
Error handling created / updated & covered by the tests aboveAligned changes with the JavaScript SDKRelease notes updated