Add unit test #42
Merged
Add unit test #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 22, 2024 15:28
- Remove unneccesary isNotNull assertions - Rename test methods
# Conflicts: # core/src/test/java/com/sap/ai/sdk/core/client/ArtifactUnitTest.java # core/src/test/java/com/sap/ai/sdk/core/client/ConfigurationUnitTest.java # core/src/test/java/com/sap/ai/sdk/core/client/DeploymentUnitTest.java # core/src/test/java/com/sap/ai/sdk/core/client/ExecutionUnitTest.java # core/src/test/java/com/sap/ai/sdk/core/client/ScenarioUnitTest.java
core/src/test/java/com/sap/ai/sdk/core/client/DeploymentUnitTest.java
Outdated
Show resolved
Hide resolved
core/src/test/java/com/sap/ai/sdk/core/client/ExecutionUnitTest.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Sep 4, 2024
CharlesDuboisSAP
previously approved these changes
Sep 16, 2024
| assertThat(execution.getConfigurationName()).isEqualTo("i749902_exec_conf"); | ||
| assertThat(execution.getCreatedAt()).isEqualTo("2024-09-09T19:09:57Z"); | ||
| // executableId is not in the generated client. | ||
| assertThat(execution.getCustomField("executableId")).isEqualTo("wt-spam-detection-i749902"); |
There was a problem hiding this comment.
You should report to AI Core that they have the field executionScheduleId instead of executableId
CharlesDuboisSAP
approved these changes
Sep 18, 2024
CharlesDuboisSAP
previously approved these changes
Sep 18, 2024
CharlesDuboisSAP
previously approved these changes
Sep 18, 2024
added 2 commits
September 18, 2024 16:09
# Conflicts: # core/src/test/java/com/sap/ai/sdk/core/client/ExecutionUnitTest.java
CharlesDuboisSAP
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
AI/ai-sdk-java-backlog#37.
Add unit test for all commonly used methods for valid response cases.
Feature scope:
Definition of Done
Error handling created / updated & covered by the tests aboveAligned changes with the JavaScript SDKDocumentation updatedRelease notes updated