-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Add explanation for service binding options #35
Conversation
README.md
Outdated
There are multiple options to register the service binding: | ||
* Regular service binding in SAP BTP Cloud Foundry (resulting in `VCAP_SERVICES` env var entry). | ||
* Set an environment variable explicitly: `AICORE_SERVICE_KEY` | ||
* Define and use a _Destination_ in _BTP Destination Service_. | ||
* Leveraging `"user-provided"` service binding (currently not recommended). | ||
* Define and use a custom `ServiceBinding` or `ServiceBindingAccessor` declaration in application (not recommended). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mention that option 1 and 4 are Cloud only, not local. The other are both local and Cloud
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've seen devs use VCAP_SERVICES
locally. Therefore I would rather not make this distinction explicit here.
|
||
</details> | ||
|
||
### Set credentials as dedicated environment variable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mention that this is recommended if you need to access an external AI Core service instance or for local use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently the README is already almost unreadable with all the details and sample code. I don't want to explain and motivate reasons for the options to resolve a service binding.
Not only because of complexity and readability, but also any documented "reasoning" is subject to change over time. I'm certain we will see changes to best-practices, once the project gains traction.
Context
AI/ai-sdk-java-backlog#56.
Explain options:
VCAP_SERVICES
env var entry).AICORE_SERVICE_KEY
Leveraging"user-provided"
service binding (currently not recommended).Define and use a customServiceBinding
orServiceBindingAccessor
declaration in application (not recommended).I chose to enhance the
README.md
(instead of starting a newdocs/
document).