Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Test Coverage for Orchestration #255

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

Jonas-Isr
Copy link
Member

Context

Test coverage of the methods in the Orchestration client was slightly below 85%.

To increase test coverage I added the two previously untested parameters of the OrchestrationAiModel class to the test instance.

Feature scope:

  • Increased test coverage of methods to above 85%.

Definition of Done

  • Functionality scope stated & covered
  • Tests cover the scope above
  • Error handling created / updated & covered by the tests above
  • Aligned changes with the JavaScript SDK
  • Documentation updated
  • Release notes updated

@Jonas-Isr Jonas-Isr added the please-review Request to review a pull-request label Jan 2, 2025
@Jonas-Isr Jonas-Isr self-assigned this Jan 2, 2025
@Jonas-Isr Jonas-Isr enabled auto-merge (squash) January 2, 2025 14:43
@Jonas-Isr Jonas-Isr merged commit fbad7a5 into main Jan 2, 2025
5 checks passed
@Jonas-Isr Jonas-Isr deleted the increase-orch-test-coverage branch January 2, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please-review Request to review a pull-request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants