Reduce duplication of ResponseHandlers #244
Conversation
# Conflicts: # docs/guides/ORCHESTRATION_CHAT_COMPLETION.md
# Conflicts: # sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/controllers/OrchestrationController.java
| <coverage.instruction>68%</coverage.instruction> | ||
| <coverage.branch>52%</coverage.branch> | ||
| <coverage.method>73%</coverage.method> | ||
| <coverage.class>87%</coverage.class> |
There was a problem hiding this comment.
orchestration tests don't count towards core coverage, therefore I separated the values into individual modules so these bad limits on the core module don't impact the other modules
|
|
||
| static { | ||
| HANDLER.JACKSON = JACKSON; | ||
| } |
There was a problem hiding this comment.
Streaming handlers will be ported in the core module in a later PR if possible
There was a problem hiding this comment.
The utility class currently has four public API accessors.
I'm feeling a little hesitant to merge this before code reduction is completed.
Let's make sure to address this before releasing 1.1.0.
core/src/main/java/com/sap/ai/sdk/core/commons/ClientError.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/sap/ai/sdk/core/commons/ClientException.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/sap/ai/sdk/core/commons/ClientResponseHandler.java
Show resolved
Hide resolved
core/src/main/java/com/sap/ai/sdk/core/commons/ClientResponseHandler.java
Outdated
Show resolved
Hide resolved
| @Slf4j | ||
| @RequiredArgsConstructor | ||
| class OrchestrationResponseHandler<T> implements HttpClientResponseHandler<T> { | ||
| public class ClientResponseHandler<T, E extends ClientException> | ||
| implements HttpClientResponseHandler<T> { |
There was a problem hiding this comment.
I'm marking this class as Beta, to discourage externals from using this class.
Maybe we can find a way to make this class not 100% dependent on Apache HTTP Client 5 API(?)
orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationError.java
Outdated
Show resolved
Hide resolved
Context
AI/ai-sdk-java-backlog#111.
Feature scope:
OrchestrationResponseHandlerandOpenAiResponseHandlerinto a genericClientResponseHandlerDefinition of Done
Aligned changes with the JavaScript SDKDocumentation updatedRelease notes updated