chore: [Orchestration] Improve Streaming Sample Code #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharlesDuboisSAP
previously approved these changes
Dec 18, 2024
newtork
reviewed
Dec 19, 2024
| "Can you give me the first " | ||
| + numberOfFibonacci | ||
| + " numbers of the Fibonacci sequence?"); | ||
| "Please create a small story about developing a software project with around 700 words."); |
There was a problem hiding this comment.
(Minor/Comment)
For sake of sample code quality and "real world" application, I would probably still prefer a service method parameter.
Suggested change
| "Please create a small story about developing a software project with around 700 words."); | |
| "Please create a small story about "+topic+" with around 700 words."); |
Jonas-Isr
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Gemini consistently refuses to generate enough numbers, and with the default chunk size of 100 barely any streaming occurs. The new prompt is more reliable