-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Html page redesign #242
Html page redesign #242
Conversation
|
|
# Conflicts: # sample-code/spring-app/src/main/resources/static/index.html
# Conflicts: # sample-code/spring-app/src/main/resources/static/index.html
I merged the current state into this branch and fixed the behavior regarding the new backend. I also added minor improvements to the code. |
<a class="link-offset-2-hover link-underline link-underline-opacity-0 link-underline-opacity-75-hover endpoint" | ||
href="/deployments/by-config/67e8d039-c7f1-4179-9f8f-60d158a36b0e/createDelete"><code>/deployments/by-config/[...]/createDelete</code></a> | ||
<div class="tooltip-content"> | ||
Create and delete a deployment with the Java specific configuration ID. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create and delete a deployment with the Java specific configuration ID. | |
Create a deployment for a configuration ID and delete after. |
Reasoning below.
<a class="link-offset-2-hover link-underline link-underline-opacity-0 link-underline-opacity-75-hover endpoint" | ||
href="/deployments/by-config/67e8d039-c7f1-4179-9f8f-60d158a36b0e/stop"><code>/deployments/by-config/[...]/stop</code></a> | ||
<div class="tooltip-content"> | ||
Stop all deployments with the Java specific configuration ID. Only RUNNING deployments can be STOPPED. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stop all deployments with the Java specific configuration ID. Only RUNNING deployments can be STOPPED. | |
Stop all deployments with a specific configuration ID. Only RUNNING deployments can be STOPPED. |
Configurations IDs are not tied to any language. Configurations listed are scoped under a resource group only.
Apart from that, I think, we should keep these details that are specific to our e2e test setup in aicore instance away from any user. I would remove it from all endpoint docs. Please get a second opinion about this.
Co-authored-by: Roshin Rajan Panackal <36329474+rpanackal@users.noreply.github.com>
Co-authored-by: Roshin Rajan Panackal <36329474+rpanackal@users.noreply.github.com>
Co-authored-by: Roshin Rajan Panackal <36329474+rpanackal@users.noreply.github.com>
Co-authored-by: Roshin Rajan Panackal <36329474+rpanackal@users.noreply.github.com>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Context
AI/ai-sdk-java-backlog#I128
I have redesigned the Frontend of our sample app, including endpoint descriptions (based on JavaDoc), JSON rendering (GitHub Repo of tool), toggling between full json view or only showing response message (for calls to LLM with message output), streaming functionality and minimal error handling.
Feature scope:
Definition of Done
Tests cover the scope aboveError handling created / updated & covered by the tests aboveAligned changes with the JavaScript SDKDocumentation updatedRelease notes updated