E2E Different Resource Group #222
Conversation
- fix type - Add tests (1 fail)
…-resource-group # Conflicts: # sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/controllers/DeploymentController.java # sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/controllers/OpenAiTest.java
- fix bug on resource group with custom destinaiton on openai - update tests
| verify(exactly(1), postRequestedFor(anyUrl()).withoutQueryParam("api-version")); | ||
| verify( | ||
| exactly(1), | ||
| postRequestedFor(anyUrl()).withQueryParam("api-version", equalTo("2024-02-01"))); |
There was a problem hiding this comment.
(Explanation)
Without the api-version we experienced resource not found error messages from AI Core.
It is a little surprising that before we verified explicitly this header would be missing (?)
There was a problem hiding this comment.
Correct, this was intended. The idea being that it is possible for users to prevent the api version from being set, e.g. for cases where the some model works without api version, or maybe it might be set automatically by long access; or if the key of that header ever changes.
That is why the javadoc of the method explicitly states to call withApiVersion afterwards
But to be fair, the above are rather hypothetical scenarios and i think it may be worthwhile to change it in favor of the more convenient approach of setting this automatically
| <dependency> | ||
| <groupId>com.sap.cloud.sdk.cloudplatform</groupId> | ||
| <artifactId>cloudplatform-connectivity</artifactId> | ||
| </dependency> |
There was a problem hiding this comment.
(Major)
Wait, why is this necessary?
Because of this code, it seems to infer HttpDestination implicitly at compilation time.
final var destination =
new AiCoreService().getInferenceDestination(resourceGroup).forModel(GPT_4O);There was a problem hiding this comment.
Without the declaration, the maven dependency plugin with goal "analyze-only" reports "Used undeclared dependencies found"
Context
AI/ai-sdk-java-backlog#123.
Include test to cover using OpenAI or Orchestration service with a different
resourceGroupthan"default".Feature scope:
Definition of Done
Error handling created / updated & covered by the tests aboveAligned changes with the JavaScript SDKDocumentation updatedRelease notes updated