Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [Core] Updated Base Path Behaviour #219

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

MatKuhr
Copy link
Member

@MatKuhr MatKuhr commented Dec 3, 2024

Context

Minor change after discussing with JS team, having the base path set automatically is the more frequent use case. While automatically setting this leads to more implicit logic, it is more convenient for most users.

Initial reasoning not to do this can be found here.

  • check if resolve still works

@MatKuhr MatKuhr added the please-review Request to review a pull-request label Dec 3, 2024
@MatKuhr MatKuhr marked this pull request as draft December 3, 2024 13:06
@MatKuhr MatKuhr changed the title change base path behaviour feat: [Core] Updated Base Path Behaviour Dec 3, 2024
@MatKuhr MatKuhr marked this pull request as ready for review December 3, 2024 14:06
Copy link
Contributor

@newtork newtork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a shame this path manipulation is so error prone in Java.

Maybe there are fewer pitfalls with URL instead of URI 🤔</cloud.sdk>

@MatKuhr MatKuhr merged commit 81b5036 into main Dec 3, 2024
5 checks passed
@MatKuhr MatKuhr deleted the feat/change-base-path-behaviour branch December 3, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please-review Request to review a pull-request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants