feat: [Orchestration] Update to Orchestration Spec 0.36.1 #203
Conversation
| $ref: "#/components/schemas/AzureThreshold" | ||
| "Sexual": | ||
| $ref: "#/components/schemas/AzureThreshold" | ||
| "Violence": |
There was a problem hiding this comment.
(Comment)
I'm wondering what makes them using " for property keys here, but nowhere else.
There was a problem hiding this comment.
My best guess is "historical reasons". git blame tells me this is from (one of) the original commits on content filtering 8 months ago.
There was a problem hiding this comment.
Here's a PR that addresses this: https://github.tools.sap/AI/llm-orchestration/pull/832
(code generation seems unaffected)
| anyOf: | ||
| - enum: | ||
| - document_grounding_service | ||
| - {} |
There was a problem hiding this comment.
(Comment/Question)
wtf is this.
There was a problem hiding this comment.
This is done for future extensibility. Without the anyof, users may complain if the enum allows additional values in the future. Not sure how strong this argument really is though..
There was a problem hiding this comment.
See also this (very related) carfuffle: OpenAPITools/openapi-diff#303
There was a problem hiding this comment.
yeah, we are also setting the flag enumUnknownDefaultCase for exactly this reason..
Context
AI/ai-sdk-java-backlog#119.
Feature scope:
Definition of Done
Error handling created / updated & covered by the tests aboveDocumentation updatedRelease notes updated