-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate release notes #200
Conversation
Successful run in my fork: /~https://github.com/Jonas-Isr/ai-sdk-java-test/pull/16 |
unchanged_sections = [ | ||
"""### 🚧 Known Issues | ||
|
||
- | ||
|
||
""", | ||
"""### 🔧 Compatibility Notes | ||
|
||
- | ||
|
||
""", | ||
"""### ✨ New Functionality | ||
|
||
- | ||
|
||
""", | ||
"""### 📈 Improvements | ||
|
||
- | ||
|
||
""", | ||
"""### 🐛 Fixed Issues | ||
|
||
- | ||
"""] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Comment/Suggestion)
I wonder whether this can be replaced with a regex.
such that we don't have to maintain the categories by hand in this python script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has never needed maintenance in the Cloud SDK, I think it's fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not experienced with regexes. Would that really be less maintenance effort than having an explicit list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also note, that you can always add your own custom categories in release_notes.md
and they will be copied. This here only ensures that no empty category (of the 4 suggested ones in the template) is copied over into the release_notes_X_to_Y
files.
Context
AI/ai-sdk-java-backlog#94
We need release notes now that we have an initial version publicly available. For this, I copied the way Cloud SDK is doing their release notes:
release-notes.md
file in underdocs/release-notes
. In a PR, you can add something to this file. This file functions as a collection of all release notes since the last (minor or major) release.release-notes-0-to-14.mdx
underdocs/release-notes
that captures all the release notes since the last major release. After every 15 minor releases, a new file is used to not avoid making this file too long (the next files will then be calledrelease-notes-15-to-29.mdx
and so on).Prepare Release
workflow, content fromrelease-notes.md
is copied to the appropriaterelease-notes-X-to-Y.mdx
file. After the release version is created, a new (empty)release-notes.md
is created for the next version.Feature scope:
release-notes.md
.release-notes.md
file.Definition of Done
Tests cover the scope aboveError handling created / updated & covered by the tests aboveAligned changes with the JavaScript SDKDocumentation updatedRelease notes updated