[OpenAPI] Trim operation name prefixes #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # core/src/main/java/com/sap/ai/sdk/core/client/ApplicationApi.java # core/src/main/java/com/sap/ai/sdk/core/client/ArtifactApi.java # core/src/main/java/com/sap/ai/sdk/core/client/ConfigurationApi.java # core/src/main/java/com/sap/ai/sdk/core/client/DeploymentApi.java # core/src/main/java/com/sap/ai/sdk/core/client/DockerRegistrySecretApi.java # core/src/main/java/com/sap/ai/sdk/core/client/ExecutableApi.java # core/src/main/java/com/sap/ai/sdk/core/client/ExecutionApi.java # core/src/main/java/com/sap/ai/sdk/core/client/ExecutionScheduleApi.java # core/src/main/java/com/sap/ai/sdk/core/client/FileApi.java # core/src/main/java/com/sap/ai/sdk/core/client/KpiApi.java # core/src/main/java/com/sap/ai/sdk/core/client/MetaApi.java # core/src/main/java/com/sap/ai/sdk/core/client/MetricsApi.java # core/src/main/java/com/sap/ai/sdk/core/client/ModelApi.java # core/src/main/java/com/sap/ai/sdk/core/client/ObjectStoreSecretApi.java # core/src/main/java/com/sap/ai/sdk/core/client/RepositoryApi.java # core/src/main/java/com/sap/ai/sdk/core/client/ResourceApi.java # core/src/main/java/com/sap/ai/sdk/core/client/ResourceGroupApi.java # core/src/main/java/com/sap/ai/sdk/core/client/ResourceQuotaApi.java # core/src/main/java/com/sap/ai/sdk/core/client/ScenarioApi.java # core/src/main/java/com/sap/ai/sdk/core/client/SecretApi.java # core/src/main/java/com/sap/ai/sdk/core/client/ServiceApi.java # core/src/main/java/com/sap/ai/sdk/core/client/model/BckndDeploymentQuotaItem.java # core/src/main/java/com/sap/ai/sdk/core/client/model/BckndDeploymentResourceQuotaResponse.java # core/src/main/java/com/sap/ai/sdk/core/client/model/BckndDeploymentUsage.java # core/src/main/java/com/sap/ai/sdk/core/client/model/BckndUsageResourcePlanItem.java # e2e-test-app/src/main/java/com/sap/ai/sdk/app/controllers/ModelsController.java
…-prefix # Conflicts: # core/src/main/java/com/sap/ai/sdk/core/Core.java # core/src/main/java/com/sap/ai/sdk/core/client/ApplicationApi.java # core/src/main/java/com/sap/ai/sdk/core/client/ArtifactApi.java # core/src/main/java/com/sap/ai/sdk/core/client/ConfigurationApi.java # core/src/main/java/com/sap/ai/sdk/core/client/DeploymentApi.java # core/src/main/java/com/sap/ai/sdk/core/client/DockerRegistrySecretApi.java # core/src/main/java/com/sap/ai/sdk/core/client/ExecutableApi.java # core/src/main/java/com/sap/ai/sdk/core/client/ExecutionApi.java # core/src/main/java/com/sap/ai/sdk/core/client/ExecutionScheduleApi.java # core/src/main/java/com/sap/ai/sdk/core/client/FileApi.java # core/src/main/java/com/sap/ai/sdk/core/client/KpiApi.java # core/src/main/java/com/sap/ai/sdk/core/client/MetaApi.java # core/src/main/java/com/sap/ai/sdk/core/client/MetricsApi.java # core/src/main/java/com/sap/ai/sdk/core/client/ObjectStoreSecretApi.java # core/src/main/java/com/sap/ai/sdk/core/client/RepositoryApi.java # core/src/main/java/com/sap/ai/sdk/core/client/ResourceApi.java # core/src/main/java/com/sap/ai/sdk/core/client/ResourceGroupApi.java # core/src/main/java/com/sap/ai/sdk/core/client/ResourceQuotaApi.java # core/src/main/java/com/sap/ai/sdk/core/client/ScenarioApi.java # core/src/main/java/com/sap/ai/sdk/core/client/SecretApi.java # core/src/main/java/com/sap/ai/sdk/core/client/ServiceApi.java # core/src/test/java/com/sap/ai/sdk/core/client/ArtifactUnitTest.java # core/src/test/java/com/sap/ai/sdk/core/client/ConfigurationUnitTest.java # core/src/test/java/com/sap/ai/sdk/core/client/DeploymentUnitTest.java # core/src/test/java/com/sap/ai/sdk/core/client/ExecutionUnitTest.java # core/src/test/java/com/sap/ai/sdk/core/client/ScenarioUnitTest.java
newtork
commented
Aug 14, 2024
Comment on lines
36
to
38
| public AiModelList getModels() { | ||
| return API.modelsGet("foundation-models", "default"); | ||
| return API.get_0("foundation-models", "default"); | ||
| } |
There was a problem hiding this comment.
(Major)
This is a problem.
Cause: Following operations resolve to the same method names + signature (String, String):
get:
tags:
- Scenario
summary: Get information about all models available in LLM global scenario
description: Retrieve information about all models available in LLM global scenario
operationId: models.getget:
tags:
- Scenario
summary: Get scenario by id
description: Retrieve details for a scenario specified by scenarioId.
operationId: scenario.getIf it was fixed, we could use the logic just fine:
- operationId: models.get
+ operationId: scenario.get_modelsI created a PR to address this inconsistency here
There was a problem hiding this comment.
The fix has been merged
# Conflicts: # core/pom.xml # core/src/main/java/com/sap/ai/sdk/core/Core.java # core/src/main/java/com/sap/ai/sdk/core/client/ApplicationApi.java # core/src/main/java/com/sap/ai/sdk/core/client/ArtifactApi.java # core/src/main/java/com/sap/ai/sdk/core/client/ConfigurationApi.java # core/src/main/java/com/sap/ai/sdk/core/client/DeploymentApi.java # core/src/main/java/com/sap/ai/sdk/core/client/DockerRegistrySecretApi.java # core/src/main/java/com/sap/ai/sdk/core/client/ExecutableApi.java # core/src/main/java/com/sap/ai/sdk/core/client/ExecutionApi.java # core/src/main/java/com/sap/ai/sdk/core/client/ExecutionScheduleApi.java # core/src/main/java/com/sap/ai/sdk/core/client/FileApi.java # core/src/main/java/com/sap/ai/sdk/core/client/KpiApi.java # core/src/main/java/com/sap/ai/sdk/core/client/MetaApi.java # core/src/main/java/com/sap/ai/sdk/core/client/MetricsApi.java # core/src/main/java/com/sap/ai/sdk/core/client/ObjectStoreSecretApi.java # core/src/main/java/com/sap/ai/sdk/core/client/RepositoryApi.java # core/src/main/java/com/sap/ai/sdk/core/client/ResourceApi.java # core/src/main/java/com/sap/ai/sdk/core/client/ResourceGroupApi.java # core/src/main/java/com/sap/ai/sdk/core/client/ResourceQuotaApi.java # core/src/main/java/com/sap/ai/sdk/core/client/ScenarioApi.java # core/src/main/java/com/sap/ai/sdk/core/client/SecretApi.java # core/src/main/java/com/sap/ai/sdk/core/client/ServiceApi.java # core/src/test/java/com/sap/ai/sdk/core/client/ArtifactUnitTest.java # core/src/test/java/com/sap/ai/sdk/core/client/ConfigurationUnitTest.java # core/src/test/java/com/sap/ai/sdk/core/client/DeploymentUnitTest.java # core/src/test/java/com/sap/ai/sdk/core/client/ExecutionUnitTest.java # core/src/test/java/com/sap/ai/sdk/core/client/ScenarioUnitTest.java # sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/controllers/DeploymentController.java
CharlesDuboisSAP
approved these changes
Sep 30, 2024
8 tasks
newtork
commented
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
AI/ai-sdk-java-backlog#53.
I've noticed the internal OpenAPI generator has means to remove operation name prefixes. This way the method names in API classes can be defused.
Definition of Done
Error handling created / updated & covered by the tests aboveAligned changes with the JavaScript SDKDocumentation updatedRelease notes updated