Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed generated packages #196

Merged
merged 5 commits into from
Nov 28, 2024
Merged

Renamed generated packages #196

merged 5 commits into from
Nov 28, 2024

Conversation

CharlesDuboisSAP
Copy link
Contributor

@CharlesDuboisSAP CharlesDuboisSAP commented Nov 28, 2024

Context

AI/ai-sdk-java-backlog#78.

package names were not final. They are now better organized before the release.

Feature scope:

-com.sap.ai.sdk.orchestration.client.model
+com.sap.ai.sdk.orchestration.model
-com.sap.ai.sdk.core.client.model
+com.sap.ai.sdk.core.model

Definition of Done

  • Functionality scope stated & covered
  • Tests cover the scope above
  • Error handling created / updated & covered by the tests above
  • Aligned changes with the JavaScript SDK
  • Documentation updated
  • Release notes updated

@CharlesDuboisSAP CharlesDuboisSAP self-assigned this Nov 28, 2024
@CharlesDuboisSAP CharlesDuboisSAP added the please-review Request to review a pull-request label Nov 28, 2024
@CharlesDuboisSAP CharlesDuboisSAP enabled auto-merge (squash) November 28, 2024 09:03
@CharlesDuboisSAP CharlesDuboisSAP merged commit 104dff0 into main Nov 28, 2024
5 checks passed
@CharlesDuboisSAP CharlesDuboisSAP deleted the generated-packages branch November 28, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please-review Request to review a pull-request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants