chore: [DevOps] Update OWASP Workflow #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatKuhr
commented
Nov 26, 2024
| @@ -7,6 +7,9 @@ on: | |||
| env: | |||
| MVN_MULTI_THREADED_ARGS: --batch-mode --no-transfer-progress --fail-at-end --show-version --threads 1C | |||
| JAVA_VERSION: 17 | |||
| CVE_CACHE_KEY: cve-db | |||
There was a problem hiding this comment.
moved from separate workflow to this workflow, because we only need the DB in this job, and unifying them is more reliable
newtork
reviewed
Nov 27, 2024
| - name: Restore CVE Database | ||
| uses: actions/cache/restore@v4 | ||
| with: | ||
| path: ${{ env.CVE_CACHE_DIR }} | ||
| key: ${{ env.CVE_CACHE_KEY }} | ||
| fail-on-cache-miss: true | ||
| # fail-on-cache-miss: true |
There was a problem hiding this comment.
Not sure how to feel about this change.
Question:
- Did the logic succeed once? I.e. have you tested it to be working?
Otherwise LGTM
There was a problem hiding this comment.
This is a temporary change, needed because the cache needs to be initially created on main branch first
Co-authored-by: Charles Dubois <103174266+CharlesDuboisSAP@users.noreply.github.com>
Co-authored-by: Charles Dubois <103174266+CharlesDuboisSAP@users.noreply.github.com>
newtork
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Test the cacheCurrently not possible, cache needs to be on main branch, and API rate limits are still restricting us