Add Response Convenience #173
Merged
+56
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationClient.java # orchestration/src/test/java/com/sap/ai/sdk/orchestration/OrchestrationUnitTest.java # pom.xml # sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/controllers/OrchestrationController.java # sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/controllers/OrchestrationTest.java
# Conflicts: # orchestration/src/test/java/com/sap/ai/sdk/orchestration/OrchestrationUnitTest.java
…esponse-Convenience#110
# Conflicts: # orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationChatResponse.java # orchestration/src/test/java/com/sap/ai/sdk/orchestration/OrchestrationUnitTest.java # sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/controllers/OrchestrationController.java # sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/controllers/OrchestrationTest.java
CharlesDuboisSAP
approved these changes
Nov 19, 2024
orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationChatResponse.java
Show resolved
Hide resolved
CharlesDuboisSAP
previously requested changes
Nov 19, 2024
orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationChatResponse.java
Outdated
Show resolved
Hide resolved
MatKuhr
requested changes
Nov 19, 2024
orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationChatResponse.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Nov 21, 2024
orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationChatResponse.java
Outdated
Show resolved
Hide resolved
MatKuhr
requested changes
Nov 21, 2024
orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationChatResponse.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Nov 21, 2024
orchestration/src/test/java/com/sap/ai/sdk/orchestration/OrchestrationUnitTest.java
Show resolved
Hide resolved
7 tasks
MatKuhr
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
AI/ai-sdk-java-backlog#110.
As an orchestration user, I want to have a convenient way of accessing the LLM result and further related information.
Feature scope:
getTokenUsage()andgetAllMessages()toOrchestrationChatResponseDefinition of Done
Error handling created / updated & covered by the tests aboveDocumentation updatedRelease notes updated