Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Masking Convenience #172

Merged
merged 8 commits into from
Nov 20, 2024
Merged

Data Masking Convenience #172

merged 8 commits into from
Nov 20, 2024

Conversation

CharlesDuboisSAP
Copy link
Contributor

Context

AI/ai-sdk-java-backlog#102.

As an orchestration user, I want to have a convenient way of configuring data masking.

Feature scope:

  • Created withDpiMaskingConfig(DpiMaskingConfig)

Definition of Done

  • Functionality scope stated & covered
  • Tests cover the scope above
  • Error handling created / updated & covered by the tests above
  • Aligned changes with the JavaScript SDK
  • Documentation updated
  • Release notes updated

@CharlesDuboisSAP CharlesDuboisSAP self-assigned this Nov 19, 2024
@CharlesDuboisSAP CharlesDuboisSAP added the please-review Request to review a pull-request label Nov 19, 2024
}

@Test
void testLLMConfig() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive by test

Copy link
Member

@MatKuhr MatKuhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MatKuhr MatKuhr merged commit 5e57895 into main Nov 20, 2024
5 checks passed
@MatKuhr MatKuhr deleted the data-masking branch November 20, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please-review Request to review a pull-request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants