Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Add SAP Cloud SDK version requirements #160

Merged
merged 7 commits into from
Nov 25, 2024

Conversation

newtork
Copy link
Contributor

@newtork newtork commented Nov 14, 2024

Context

Related backlog item:

Related automatic testing:

Tested via

mvn clean package spring-boot:run -pl :spring-app -Dcloud-sdk.version=5.6.0 -Denforcer.skip=true

Copy link
Member

@MatKuhr MatKuhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does 5.6.0 not break with the apache changes? The we are setting the http client version explicitly in the ai sdk, so how does this not clash?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-authored-by: Matthias Kuhr <52661546+MatKuhr@users.noreply.github.com>
@newtork
Copy link
Contributor Author

newtork commented Nov 15, 2024

We are setting the http client version explicitly in the AI SDK.

If I see correctly, there is no explicit version. We just declare the dependency explicitly for code quality purposes, since we interact with the API directly. I.e. not make "enforcer" plugin angry.

so how does this not clash?

Luckily, in AI SDK we are not using Apache API that was subject to changes over the minor version diff.

@newtork newtork added the please-review Request to review a pull-request label Nov 25, 2024
README.md Outdated Show resolved Hide resolved
Co-authored-by: Matthias Kuhr <52661546+MatKuhr@users.noreply.github.com>
@MatKuhr MatKuhr merged commit 782e248 into main Nov 25, 2024
5 checks passed
@MatKuhr MatKuhr deleted the doc/cloud-sdk-requirements branch November 25, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please-review Request to review a pull-request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants