Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't need /v2 #159

Merged
merged 3 commits into from
Nov 18, 2024
Merged

don't need /v2 #159

merged 3 commits into from
Nov 18, 2024

Conversation

Terry-Huang-00
Copy link
Contributor

I have tried the first version, if I add /v2, it will return 404 error.

Context

AI/ai-sdk-java-backlog#ISSUENUMBER.

Please provide a short description of what your change does and why it is needed.

Feature scope:

  • Task1
  • Task2
    • SubTask1

Definition of Done

  • Functionality scope stated & covered
  • Tests cover the scope above
  • Error handling created / updated & covered by the tests above
  • Aligned changes with the JavaScript SDK
  • [X ] Documentation updated
  • Release notes updated

I have tried the first version, if I add /v2, it will return 404 error.
Copy link

cla-assistant bot commented Nov 14, 2024

CLA assistant check
All committers have signed the CLA.

@MatKuhr
Copy link
Member

MatKuhr commented Nov 15, 2024

@Terry-Huang-00 please sign the CLA so this PR can be merged

@CharlesDuboisSAP CharlesDuboisSAP merged commit 9cd08d1 into SAP:main Nov 18, 2024
3 checks passed
@Terry-Huang-00 Terry-Huang-00 deleted the patch-1 branch November 19, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants