Added Response Convenience #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatKuhr
reviewed
Nov 14, 2024
There was a problem hiding this comment.
What about the other aspects like token usage?
Otherwise lgtm. While I would prefer a bit stronger separation to our generated code, I can't think of a specific scenario where the inheritance will break sonerhing. The main downside of the inheritance IMO is that the most used convenience methods get buried among the generated getters and setters. But currently there are not too many of those on the root response object, so should be fine
orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationResponse.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Nov 14, 2024
orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationResponse.java
Outdated
Show resolved
Hide resolved
added 2 commits
November 14, 2024 14:31
# Conflicts: # orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationClient.java # orchestration/src/test/java/com/sap/ai/sdk/orchestration/OrchestrationUnitTest.java # pom.xml # sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/controllers/OrchestrationController.java # sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/controllers/OrchestrationTest.java
MatKuhr
reviewed
Nov 14, 2024
orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationResponse.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Nov 18, 2024
...i/src/main/java/com/sap/ai/sdk/foundationmodels/openai/model/OpenAiChatCompletionOutput.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Nov 18, 2024
orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationResponse.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Nov 18, 2024
orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationResponse.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Nov 18, 2024
orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationResponse.java
Outdated
Show resolved
Hide resolved
# Conflicts: # orchestration/src/test/java/com/sap/ai/sdk/orchestration/OrchestrationUnitTest.java
…esponse-Convenience#110
MatKuhr
approved these changes
Nov 18, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
AI/ai-sdk-java-backlog#110.
As an orchestration user, I want to have a convenient way of accessing the LLM result and further related information.
Feature scope:
OrchestrationResponsethat wrapsCompletionPostResponse.Definition of Done
Release notes updated