Openapi generator orchestration #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce a generic fallback and LLMModuleResult specific deserializers. - Generator ignoring all interfaces - Adapt jackson annotations
# Conflicts: # orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationClient.java # orchestration/src/test/java/com/sap/ai/sdk/orchestration/OrchestrationUnitTest.java # sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/controllers/OrchestrationController.java # sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/controllers/OrchestrationTest.java
newtork
reviewed
Nov 11, 2024
orchestration/src/main/java/com/sap/ai/sdk/orchestration/client/model/LLMModuleResult.java
Show resolved
Hide resolved
newtork
reviewed
Nov 11, 2024
orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationClient.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Nov 11, 2024
orchestration/src/main/java/com/sap/ai/sdk/orchestration/LLMModuleResultDeserializer.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Nov 11, 2024
orchestration/src/main/java/com/sap/ai/sdk/orchestration/client/model/FilterConfig.java
Outdated
Show resolved
Hide resolved
added 4 commits
November 12, 2024 11:05
…SAP/ai-sdk-java into openapi-generator-orchestration # Conflicts: # orchestration/src/main/java/com/sap/ai/sdk/orchestration/client/model/AzureContentSafetyFilterConfig.java
- Make deserializer lenient to allowed values
newtork
reviewed
Nov 12, 2024
newtork
reviewed
Nov 12, 2024
newtork
reviewed
Nov 12, 2024
orchestration/src/main/java/com/sap/ai/sdk/orchestration/LLMModuleResultDeserializer.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Nov 12, 2024
orchestration/src/main/java/com/sap/ai/sdk/orchestration/NoTypeInfoMixin.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Nov 12, 2024
orchestration/src/test/java/com/sap/ai/sdk/orchestration/LLMModuleResultDeserializerTest.java
Show resolved
Hide resolved
newtork
reviewed
Nov 12, 2024
Comment on lines
+30
to
+35
| assertThat( | ||
| ((LLMModuleResultSynchronous) result.getOrchestrationResult()) | ||
| .getChoices() | ||
| .get(0) | ||
| .getMessage() | ||
| .getContent()) |
There was a problem hiding this comment.
(Question/Major)
If I understand correctly, the PR changes public API in a way, that requires users to cast a result object to a specific class, before being able to read the response content. Is that correct? Is that the expected result?
Please also update the /docs/guides/ orchestration document.
There was a problem hiding this comment.
Note: this will be fixed by either AI/ai-sdk-java-backlog#110 or https://github.tools.sap/AI/llm-orchestration/pull/753
newtork
reviewed
Nov 12, 2024
.../src/main/java/com/sap/ai/sdk/orchestration/client/model/SearchDocumentKeyValueListPair.java
Outdated
Show resolved
Hide resolved
MatKuhr
reviewed
Nov 13, 2024
orchestration/src/main/java/com/sap/ai/sdk/orchestration/ConfigToRequestTransformer.java
Outdated
Show resolved
Hide resolved
* Simplifications and cleanup * Remove parsing for streaming
newtork
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
AI/ai-sdk-java-backlog#99.
Support oneOf from Orchestration spec using OpenAPI code generator.
Avoid template and spec modification.
Feature scope:
Definition of Done
Error handling created / updated & covered by the tests aboveAligned changes with the JavaScript SDKDocumentation updatedRelease notes updated