feat: Improve Orchestration Sample Code #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatKuhr
commented
Nov 5, 2024
| .filter(entity -> entity != DPIEntities.UNKNOWN_DEFAULT_OPEN_API) | ||
| .map(entity -> DPIEntityConfig.create().type(entity)) | ||
| .toList(); | ||
| private static CompletionPostRequest prepareRequest( |
There was a problem hiding this comment.
helper methods are more typical and easier to understand
| }; | ||
| @GetMapping("/completion") | ||
| @Nonnull | ||
| public CompletionPostResponse completion() { |
There was a problem hiding this comment.
Added a simple completion, since templating is optional (and potentially easier to do in other places of the code).
| ChatMessage.create() | ||
| .role("system") | ||
| .content( | ||
| "Please evaluate the following user feedback and judge if the sentiment is positive or negative."); |
There was a problem hiding this comment.
IMO the CV was a bit too long and doesn't make the difference between anon / pseudo clear, thus the switch to this use case.
…leanup' into chore/sample-code-cleanup
Merged
CharlesDuboisSAP
requested changes
Nov 6, 2024
* Charles review of orchestration sample code * More fixes
CharlesDuboisSAP
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR updates the orchestration sample code to be more realistic and more concise.
Also, the E2E test assertions are improved to assert on expected output.
Definition of Done
Error handling created / updated & covered by the tests aboveAligned changes with the JavaScript SDKDocumentation updatedRelease notes updated