Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Spotbugs by default #109

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Run Spotbugs by default #109

merged 2 commits into from
Oct 22, 2024

Conversation

newtork
Copy link
Contributor

@newtork newtork commented Oct 21, 2024

  • Make the code quality related plugins runnable from sub modules.
  • Enable Spotbugs by default

Sample output:

mvn clean install -f core

[...]

[INFO] 
[INFO] --- spotbugs:4.8.6.4:check (default) @ core ---
[INFO] BugInstance size is 2
[INFO] Error size is 0
[INFO] Total bugs: 2
[ERROR] High: com.sap.ai.sdk.core.client.model.AiDeployment$LastOperationEnum.fromValue(String) may return null, but is declared @Nonnull [com.sap.ai.sdk.core.client.model.AiDeployment$LastOperationEnum] At AiDeployment.java:[line 181] NP_NONNULL_RETURN_VIOLATION
[ERROR] High: com.sap.ai.sdk.core.client.model.AiDeploymentResponseWithDetails$LastOperationEnum.fromValue(String) may return null, but is declared @Nonnull [com.sap.ai.sdk.core.client.model.AiDeploymentResponseWithDetails$LastOperationEnum] At AiDeploymentResponseWithDetails.java:[line 181] NP_NONNULL_RETURN_VIOLATION
[INFO] 


To see bug detail using the Spotbugs GUI, use the following command "mvn spotbugs:gui"



[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:03 min
[INFO] Finished at: 2024-10-21T10:14:48+02:00
[INFO] ------------------------------------------------------------------------

@MatKuhr MatKuhr merged commit 2d712cb into main Oct 22, 2024
5 checks passed
@MatKuhr MatKuhr deleted the spotbugs/run-by-default branch October 22, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants