Avoid clobbering v8-v15 registers #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the AArch64 ABI, v8-v15 are callee-saved, but only their lower 64 bits, which means we were inadvertently overwriting part of their values. This patch entirely removes the usage of these registers, we have plenty of them to work with!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the AArch64 ABI, v8-v15 are callee-saved, but only their lower
64 bits, which means we were inadvertently overwriting part of their
values.
This patch entirely removes the usage of these registers, we have plenty
of them to work with!
Sorry about #12, I force-pushed from the wrong repository…