remove build folder #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise, a new advertiseId would be generated, making it impossible to properly unadvertise
|
Issue re-opened. Bower packages are something that seems to be coming up a lot in various requests. If having the compiled library makes this easier, I think we should have it. It also makes testing the examples with local changes easier. |
|
One more thing: bower supports commands like |
|
:p whomp. Okay, we can add it back then. |
T045T
added a commit
that referenced
this pull request
Jun 16, 2014
Also add back build folder, so users can do ```bower install roslibjs#develop``` - this should also put #85 and #86 to rest. [ ] [Register](http://bower.io/#registering-packages) roslibjs with bower
k-aguete
pushed a commit
to k-aguete/roslibjs
that referenced
this pull request
Oct 21, 2022
Fix for ROS3D.Viewer clear color, use parseInt in order to convert hex s...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove the redundant build folder and have the examples use hosted versions of roslib.js instead. All examples have been tested with Hydro.
Plus another fix to advertise/unadvertise functionality.