replace xmlshim with xmldom #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xmldom is a full JavaScript implementation of DOMParser with the same functionality. It is a lot more used and so I think it is more reliable. As a result this project will no longer depend on libxmljs which makes it easier to install on platforms such as windows.
| @@ -114,7 +114,7 @@ describe('URDF', function() { | |||
| it('is ignorant to the xml node', function(){ | |||
| var parser = new DOMParser(); | |||
| var xml = parser.parseFromString(sample_urdf(), 'text/xml'); | |||
| var robotXml = xml.evaluate('//robot', xml, null, XPATH_FIRST_ORDERED_NODE_TYPE, null).singleNodeValue; | |||
| var robotXml = xml.documentElement; | |||
There was a problem hiding this comment.
Nice!!! Great stuff @Rayman
k-aguete
pushed a commit
to k-aguete/roslibjs
that referenced
this pull request
Oct 21, 2022
…Tools#190) * add another event handler for intersection without highliting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xmldom is a full JavaScript implementation of DOMParser with the same functionality. It is a lot more used and so I think it is more reliable (217.411 downloads in the last week vs 88).
As a result this project will no longer depend on libxmljs which makes it easier to install on platforms such as windows. All tests on both node and browser still run.
As a side effect I had to reintroduce
shim/xmldom.jsto keep the build size small. I also replaced the xpathevaluatecall withdocumentElementbecause we no longer have that. Could that become a problem?